Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DH-14439 Fix QueryMonitor breaking on "null" in default search filter #1159

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

vbabich
Copy link
Collaborator

@vbabich vbabich commented Mar 17, 2023

Allow null in match filters on string columns, treat it as a regular string value.

Testing steps:

Run this query:

from deephaven import empty_table
a = [None, 'Null', 'null - starts with', 'ends with null', 'null', 'ABC']
test_table = empty_table(6).update(formulas=["X = (String)a[i]"])

Filter using quick filters treating null as a string:

  • *null, =*null, !=*null - ends with, does not end with
  • null*, =null*, !=null* - starts with, does not start with
  • ~null, !~null - contains/does not contain

Special cases treating null as a null value:

  • =null, !=null

@vbabich vbabich self-assigned this Mar 17, 2023
@vbabich vbabich requested a review from mofojed March 17, 2023 16:13
@vbabich vbabich merged commit ac6a514 into deephaven:main Mar 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants